Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): re-introduce install package using shell spawn #16112

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 8, 2019

This works around a Windows CI failure that related to the PATH environment variable and a failure to located the npm command.

This works around a Windows CI failure that related to the PATH environment variable and a failure to located the `npm` command.
@clydin clydin marked this pull request as ready for review November 8, 2019 01:58
@clydin clydin added the target: major This PR is targeted for the next major release label Nov 8, 2019
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Nov 8, 2019
@alan-agius4
Copy link
Collaborator

Should also fix #16115

@mgechev mgechev merged commit b8257e2 into angular:master Nov 8, 2019
mgechev pushed a commit that referenced this pull request Nov 8, 2019
…6112)

This works around a Windows CI failure that related to the PATH environment variable and a failure to located the `npm` command.
@clydin clydin deleted the workaround-win-ci-shell branch November 8, 2019 16:01
@SenthilKumaranC
Copy link

SenthilKumaranC commented Nov 12, 2019

How to update angular cli with this patch?

npm install --save-dev @angular/cli@xxxxxxx

Edit : I have modified install-package.js and added shell : true , now ng add working!!!!!

clydin added a commit to clydin/angular-cli that referenced this pull request Nov 20, 2019
…gular#16112)

This works around a Windows CI failure that related to the PATH environment variable and a failure to located the `npm` command.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants